Add all functionality from ironoxide-java #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giarc3
commented
Jan 17, 2020
giarc3
commented
Jan 17, 2020
coltfred
requested changes
Jan 23, 2020
clintfred
suggested changes
Jan 23, 2020
clintfred
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to make ironoxide-java and ironoxide-scala fully consistent in functionality. Adds many functions and classes. Adds some folders for usability, but keeps everything in one package.
Please let me know what tests you think would be reasonable, as we are (hopefully) soon changing all of our tests in this project [#1]