-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and remove group admins #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested a couple of small comment changes, and also wondering if we want integration tests.
Co-Authored-By: Clint Frederickson <[email protected]>
@giarc3 Be sure to update the feature matrix spreadsheet.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion that could protect against java sdk throwing.
groupAddAdmins()
to add a list ofUserIds
as admins to a givenGroupId
groupRemoveAdmins()
to remove a list of adminUserIds
from a givenGroupId
GroupAccessEditResult
to reduce code duplication in IronSdkSync