Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and remove group admins #29

Merged
merged 5 commits into from
Oct 30, 2019
Merged

Add and remove group admins #29

merged 5 commits into from
Oct 30, 2019

Conversation

giarc3
Copy link
Member

@giarc3 giarc3 commented Oct 25, 2019

  • Added groupAddAdmins() to add a list of UserIds as admins to a given GroupId
  • Added groupRemoveAdmins() to remove a list of admin UserIds from a given GroupId
  • Added new constructor to GroupAccessEditResult to reduce code duplication in IronSdkSync

@giarc3 giarc3 requested a review from clintfred October 28, 2019 20:07
Copy link
Contributor

@clintfred clintfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a couple of small comment changes, and also wondering if we want integration tests.

src/main/scala/com/ironcorelabs/GroupAccessEditErr.scala Outdated Show resolved Hide resolved
src/main/scala/com/ironcorelabs/IronSdk.scala Outdated Show resolved Hide resolved
Co-Authored-By: Clint Frederickson <[email protected]>
@clintfred
Copy link
Contributor

@giarc3 Be sure to update the feature matrix spreadsheet....

Copy link
Member

@coltfred coltfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion that could protect against java sdk throwing.

@giarc3 giarc3 requested a review from coltfred October 30, 2019 20:38
@giarc3 giarc3 merged commit bc8a892 into master Oct 30, 2019
@giarc3 giarc3 deleted the 25-add-remove-group-admins branch October 30, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants