Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for handling file paths as UTF8 #89

Merged
merged 1 commit into from
Oct 21, 2017

Conversation

wcogan
Copy link
Contributor

@wcogan wcogan commented Oct 21, 2017

Fix for issue #88; all paths are handled as Unicode (UTF-8) so it should support all languages and any random symbols in the file path.

Tested with a folder named "Test™®ėఌ ఎ す ず ㌌ ㌍ ﻙ ﻚƋ ƌ ƍԹ Ժ Ի ֤ ֥" (Unicode symbols grabbed at random). Nested folders worked fine, too.

@Iridium-IO Iridium-IO merged commit a3fce05 into IridiumIO:development Oct 21, 2017
@Iridium-IO
Copy link
Member

Iridium-IO commented Oct 21, 2017

Thanks for that :)
I just tested it, and using CHCP 437 still works for the input, but it just gets replaced in the output window. Can you verify this?
I'd like to keep CHCP 437 for now as it fixes localisation for some users while I work on a more robust solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants