Added slot removal option to island menu #868
Conversation
honestly cant believe it was a one line fix smh
| @@ -33,6 +33,8 @@ public void noArgsDefault(@NotNull CommandSender commandSender) { | |||
| Player player = (Player) commandSender; | |||
| User user = IridiumSkyblock.getInstance().getUserManager().getUser(player); | |||
| if (IridiumSkyblock.getInstance().getTeamManager().getTeamViaID(user.getTeamID()).isPresent()) { | |||
|
|
|||
| IridiumSkyblock.getInstance().getInventories().islandMenu.items.values().removeIf(item -> item.slot == -1); | |||
There was a problem hiding this comment.
So this will remove the thing from the config, if the slot is -1.
Alternitavly you can also add an if statement here https://github.com/Iridium-Development/IridiumTeams/blob/master/src/main/java/com/iridium/iridiumteams/gui/InventoryConfigGUI.java#L36
So we just dont add it to the GUI if the slot is < 0.
I dont really know what the better solution is here, I guess it really just depends on if we want it to be deleted from the config or not
There was a problem hiding this comment.
Im not really fussed either way, so ive approved this and ill let you decide on which one you want to go for
There was a problem hiding this comment.
i would rather use this, you can go ahead and close this pr in favor of teams
honestly cant believe it was a one line fix smh