add a new convert workflow that will supplant the docs build #80
Conversation
.github/workflows/test.yml
Outdated
| - name: init playwright nbconvert-a11y | ||
| run: | | ||
| conda activate test-nbconvert-a11y | ||
| playwright install --with-deps chrome |
There was a problem hiding this comment.
this is an excellent candidate for caching, if it puts its downloaded files in a sensible, predictable place
There was a problem hiding this comment.
i'll add this to the to do list. i wanna get to this using the discussion in microsoft/playwright#7249
| activate-environment: test-nbconvert-a11y | ||
| channel-priority: strict | ||
| auto-activate-base: true | ||
| environment-file: test-environment.yml |
There was a problem hiding this comment.
to win CI, you really want to be solving this offline with conda-lock.
There was a problem hiding this comment.
i will start doing that. thanks! the solve does delay the action significantly
| run: | | ||
| python -m hatch run docs:build | ||
| - name: Deploy main 🚀 | ||
| uses: JamesIves/github-pages-deploy-action@v4 |
There was a problem hiding this comment.
recall you can do all of this with the built-in GHA options, not... whatever this is.
There was a problem hiding this comment.
okay. cool. been using this for a real long. ill find the more appropirate action
.github/workflows/test.yml
Outdated
| key: | ||
| ${{ runner.os }}-conda-${{ env.CACHE_NUMBER }}-${{ | ||
| hashFiles('test-environment.yml') }} | ||
| - uses: conda-incubator/setup-miniconda@v2 |
There was a problem hiding this comment.
As a greenfield project, you could also consider the smaller-scope https://github.com/mamba-org/setup-micromamba
|
the playwright tests are finally running. 🎉 right now, i am getting a target size error on cf: https://adrianroselli.com/2022/05/24x24-pixel-cursor-bookmarklet.html |
|
we currently have reached a baseline for axe tests using wcag 2.1 a, aa and wcag 2.2 aa with out current testing notebooks. |
begins to address #77
pytesttesting phase coupled with pytest-xdist for speed ups. audits are saved to when executed. this phase of playwright is for unit testing the library.open questions: