Add tags for emphasis format. #7
Conversation
| @@ -25,6 +25,22 @@ function indent(content, spaces, ignoreFirst) { | |||
| }).join("\n"); | |||
| } | |||
|
|
|||
| function emphasisFormats( text ) { | |||
| return { | |||
| strong: '**', | |||
There was a problem hiding this comment.
Please use 4 space indent and double quotes. Also put the commas at the beginning of the lines.
There was a problem hiding this comment.
Sounds good, @IonicaBizau how about adding a .editorconfig file in order to allow others to have your same code style in your repo, is something I use usually to allow other follow same rules in code style.
Let me know your comments if so to add an .editorconfig file.
There was a problem hiding this comment.
@mitogh I have no experience in using such configuration files for how the syntax should look like. Any ideas you have, please comment in IonicaBizau/code-style#4. There is a similar discussion. I need help in writing such a file. 😄
There was a problem hiding this comment.
Sounds good I will add some comments there.
Thank you 👍
|
@mitogh Nice work! ✨ I left a bunch of comments. Generally they are syntax (code style) fixes. Don't forget to add yourself as contributor in |
|
Changes has been updated based on your feedback. Let me know your comments @IonicaBizau |
No description provided.