Support adding custom env vars when using ProcessRunner to run a process#221
Merged
Conversation
Enhanced `ProcessRunner` to support adding custom environment variables via `ProcessRunOptions`. Updated logging to include environment variables when applicable (secrets will still be masked).
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom environment variables when using ProcessRunner to execute processes. The implementation allows users to specify environment variables through the ProcessRunOptions class, which are then applied to the process during execution.
- Added EnvironmentVariables property to ProcessRunOptions as a Dictionary<string, string?>
- Updated logging logic in both Run and RunAsync methods to handle different combinations of WorkingDirectory and EnvironmentVariables
- Implemented environment variable setting in process StartInfo for both synchronous and asynchronous execution paths
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| DecSm.Atom/Process/ProcessRunOptions.cs | Added EnvironmentVariables property with comprehensive documentation |
| DecSm.Atom/Process/ProcessRunner.cs | Enhanced logging and added environment variable configuration for process execution |
| Multiple .csproj files | Updated package dependencies to newer versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.