Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-240,SV-15] Fix infinite loop after payment #176

Merged
merged 13 commits into from
Aug 1, 2024

Conversation

zuk3975
Copy link
Contributor

@zuk3975 zuk3975 commented Jul 10, 2024

related issues https://invertus.atlassian.net/browse/SV-15
https://invertus.atlassian.net/browse/SL-240

Move ajax getStatus action to dedicated controller;
Allow asserting transaction without updating saferpayOrder (which was the main cause causing the loop, because during getStatus it used to mess up saferPayOrder values).
This seems to prevent endless loop when waiting for return.

@zuk3975 zuk3975 changed the base branch from master to release-1.2.3 July 10, 2024 19:23
@zuk3975 zuk3975 changed the title Fix infinite loop after payment [SL-240,SV-15] Fix infinite loop after payment Jul 10, 2024
Copy link

cypress bot commented Jul 11, 2024

Passing run #42 ↗︎

0 0 1 0 Flakiness 0

Details:

fix loop by separating controller and allow asserting without update
Project: Saferpay Commit: 55cebc49ff
Status: Cancelled Duration: 47:57 💡
Started: Jul 11, 2024 12:32 PM Ended: Jul 11, 2024 1:20 PM

Review all test suite changes for PR #176 ↗︎

@GytisZum GytisZum merged commit 008f558 into release-1.2.3 Aug 1, 2024
@GytisZum GytisZum deleted the fix-loop-and-assert-write branch August 1, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants