Force ambiguity for annotations in CEK #7189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/benchmark lists it shouldn't differ really. core didn't change |
Contributor
|
Click here to check the status of your benchmark. |
SeungheonOh
commented
Jul 8, 2025
| forgetAnn :: forall ann uni fun. NTerm uni fun ann -> NTerm uni fun Any | ||
| forgetAnn = unsafeCoerce | ||
|
|
||
| rememberAnn :: forall ann uni fun. NTerm uni fun Any -> NTerm uni fun ann |
SeungheonOh
commented
Jul 8, 2025
| Starting term -> pure $ Computing NoFrame Env.empty term | ||
| Computing ctx env term -> computeCek ctx env term | ||
| Starting term -> pure $ Computing NoFrame Env.empty (forgetAnn term) | ||
| Computing ctx env term -> computeCek ctx env (rememberAnn term) |
Collaborator
Author
There was a problem hiding this comment.
This is only safe if Computing ... is constructed by cekTrans which is not ideal. Probably, it is possible to have some witness value to allow this conditionally
Contributor
|
SeungheonOh
force-pushed
the
sho/use-any-on-cek
branch
from
6775175 to
2c3fb0a
Compare
Contributor
|
Comparing benchmark results of 'lists' on 'f0aca4d2d' (base) and '677517527' (PR) Results table
|
effectfully
suggested changes
Jul 8, 2025
Comment on lines
+170
to
+174
| forgetAnn :: forall ann uni fun. NTerm uni fun ann -> NTerm uni fun Any | ||
| forgetAnn = unsafeCoerce | ||
|
|
||
| rememberAnn :: forall ann uni fun. NTerm uni fun Any -> NTerm uni fun ann | ||
| rememberAnn = unsafeCoerce |
Contributor
There was a problem hiding this comment.
Ugh, I'm really uncomfortable about that. Let's discuss it during the tech meeting.
Collaborator
Author
|
I agree. Also, less reason to pursue this as there's a proper way for #7188. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Cek, we intentionally maintain ambiguity of the annotation type for performance reasons(I assume). This PR makes it so that this ambiguity is forcefully enforced by using
GHC.Exts.Anyas the annotation type. This reduces some noise on the types while also allowing construction of UPLC nodes within CEK in nicer way, which is what I needed for thisSteppableCek is a bit messy because its context can hold annotations, so it would require more coercsions.