PlutusTx.Data.List & PlutusTx.BuiltinList - Feature Parity #7055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yura <[email protected]>
Unisay
reviewed
May 29, 2025
Comment on lines
8
to
12
| \(xs : list integer) -> | ||
| let | ||
| !x : Unit = trace {Unit} "PT21" Unit | ||
| in | ||
| error {integer} |
Contributor
There was a problem hiding this comment.
What an optimisation!
However, you might want to switch optimisations off, as they go too far reducing this test to the form where its not testing what you want in runtime, instead eliminating the whole problem (test setup) in compile time.
Unisay
reviewed
May 29, 2025
| (constr 0 []) | ||
| (constr 0 [])))) | ||
| (\str -> (\x -> error) (force trace str (constr 0 []))))) No newline at end of file | ||
| (program 1.1.0 (\xs -> (\x -> error) (force trace "PT21" (constr 0 [])))) No newline at end of file |
Contributor
There was a problem hiding this comment.
Same here: the aspect you're trying to test (how are negative indexes handled) got optimised away.
Unisay
reviewed
May 29, 2025
| let | ||
| !x : Unit = trace {Unit} "PT22" Unit | ||
| in | ||
| error {Unit -> integer}) |
Contributor
There was a problem hiding this comment.
Looks like error here is unconditional too...
Unisay
reviewed
May 29, 2025
| ((\x xs ds _ann -> x) (force headList l) (force tailList l)))) | ||
| (constr 0 []) | ||
| (constr 0 [])) | ||
| (force dropList 10 xs))) |
Contributor
There was a problem hiding this comment.
ifThenElse got eliminated...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlutusTx.Data.ListandPlutusTx.BuiltinList.mayMaybefunction toPlutusTx.List"PT23","PT24","PT25"error codes