-
Notifications
You must be signed in to change notification settings - Fork 501
[Builtins] Allow casing on booleans and integers #7029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Builtins] Allow casing on booleans and integers #7029
Conversation
8358a8f to
5244c96
Compare
5244c96 to
8b55532
Compare
8b55532 to
2344b92
Compare
2344b92 to
c0df0c1
Compare
|
/benchmark nofib |
1 similar comment
|
/benchmark nofib |
|
/benchmark lists |
1 similar comment
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '27d2bc3905' (base) and 'c0df0c158b' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '27d2bc3905' (base) and 'c0df0c158b' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '27d2bc3905' (base) and 'c0df0c158b' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '27d2bc3905' (base) and 'c0df0c158b' (PR) Results table
|
c0df0c1 to
06d1a16
Compare
…to effectfully/builtins/allow-casing-on-booleans
|
Comparing benchmark results of 'lists' on '5de23f72a' (base) and '2eb18cd89' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '5de23f72a' (base) and '2eb18cd89' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'marlowe' on '5de23f72a' (base) and '2eb18cd89' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'bls12-381-benchmarks' on '5de23f72a' (base) and '2eb18cd89' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
/benhcmark lists |
2 similar comments
|
/benhcmark lists |
|
/benhcmark lists |
2eb18cd to
803c53b
Compare
…to effectfully/builtins/allow-casing-on-booleans
ca956fe to
ba9750e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@effectfully We probably need more conformance tests for case here, like testing that it does work on booleans and integers (depending on the Plutus version) and that it doesn't work on other types (but that's OK as long as it's not fully applied). There's also the question of what happens about missing branches.
Any new tests will probably have to be excluded from agda-conformance because I don't think the metatheory knows about case and non-constr yet.
In some cases in the past we've obtained end-to-end tests by promoting the conformance tests, so if these are as comprehesive as possible it might make the end-to-end tests a bit easier.
This adds support for casing on booleans and integers using
Case, which is the first part of #6602.