[Builtins] Add 'ListToConstr' and 'DataToConstr' #5704
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/benchmark plutus-benchmark:lists |
|
Click here to check the status of your benchmark. |
…to effectfully/builtins/add-ListToConstr
|
/benchmark plutus-benchmark:lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'plutus-benchmark:lists' on 'b8a74e7b4' (base) and '9d99fc6ed' (PR) Results table
|
|
/benchmark plutus-benchmark:lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'plutus-benchmark:lists' on 'b8a74e7b4' (base) and 'a8183017d' (PR) Results table
|
|
/benchmark plutus-benchmark:lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'plutus-benchmark:lists' on 'b8a74e7b4' (base) and 'a8183017d' (PR) Results table
|
effectfully
added
Do not merge
Builtins
EXPERIMENT
zeme-wana
force-pushed
the
master
branch
2 times, most recently
from
a161078 to
db5cabb
Compare
|
We are not doing this as per #5711, hence closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a competitor of #5486, let's see how it performs.
This adds the
listToConstrbuiltin whose Plutus type isThe idea is that we can use this builtin to implement faster pattern matching over built-in lists by piggy-backing on
casethat we use for pattern matching over sums-of-products:Implementation-wise this requires us to add the following class:
and add it to
HasMeaningIn uni val.The meaning of the
listToConstrbuiltin is implemented as follows:i.e. it simply turns the outer constructor of a list into an SOP term leaving all other constructors of the list intact.
The only interesting remaining part is that we make
matchListanInternalbuiltin (i.e. aNOINLINEone) and tell the plugin to replace that builtin with the definition ofmatchListgiven above.