Replace `#!/bin/bash` with `#!/usr/bin/env bash` #618

eyeinsky · 2022-07-22T10:48:04Z

Pre-submit checklist:

Branch
- Tests are provided (if possible)
- Commit sequence broadly makes sense
- Key commits have useful messages
- Formatting, PNG optimization, etc. are updated
PR
- Self-reviewed the diff
- Useful pull request description
- Reference the ADR in the PR and reference the PR in the ADR (if revelant)
- Reviewer requested

whs-dot-hk · 2022-07-26T12:16:05Z

It seems that the person wrote the script have bash in /bin/bash. Which the binaries are in /bin, but this commit assume the binaries (at least env) are in /usr/bin

whs-dot-hk · 2022-07-26T13:01:41Z

Tested should work in devcontainer

Replace #!/bin/bash with #!/usr/bin/env bash

f92cdce

eyeinsky requested a review from koslambrou July 22, 2022 10:48

eyeinsky mentioned this pull request Jul 22, 2022

Add missing field #617

Merged

8 tasks

koslambrou approved these changes Jul 22, 2022

View reviewed changes

koslambrou merged commit 5269cdb into main Jul 27, 2022

koslambrou deleted the ml/shebang-fix branch July 27, 2022 11:29

eyeinsky mentioned this pull request Jul 28, 2022

PLT-172: Marconi index transactions that have been issued to a particular script #629

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace `#!/bin/bash` with `#!/usr/bin/env bash` #618

Replace `#!/bin/bash` with `#!/usr/bin/env bash` #618

eyeinsky commented Jul 22, 2022

whs-dot-hk commented Jul 26, 2022 •

edited

Loading

whs-dot-hk commented Jul 26, 2022 •

edited

Loading

Replace #!/bin/bash with #!/usr/bin/env bash #618

Replace #!/bin/bash with #!/usr/bin/env bash #618

Conversation

eyeinsky commented Jul 22, 2022

whs-dot-hk commented Jul 26, 2022 • edited Loading

whs-dot-hk commented Jul 26, 2022 • edited Loading

Replace `#!/bin/bash` with `#!/usr/bin/env bash` #618

Replace `#!/bin/bash` with `#!/usr/bin/env bash` #618

whs-dot-hk commented Jul 26, 2022 •

edited

Loading

whs-dot-hk commented Jul 26, 2022 •

edited

Loading