Skip to content
This repository was archived by the owner on Dec 2, 2024. It is now read-only.

Bootstrap Architectural Design Records (ADR) in our documentation #512

Merged
merged 3 commits into from
Jun 23, 2022

Conversation

koslambrou
Copy link
Contributor

@koslambrou koslambrou commented Jun 10, 2022

Added a new section in our readthedocs.

Ultimately, this should be place where we document, propose and comment any architectural and design decisions in plutus-apps.

See: https://plutus-apps--512.org.readthedocs.build/en/512/

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@koslambrou koslambrou requested a review from joseph-fajen June 10, 2022 19:39
@koslambrou koslambrou force-pushed the PLT-358-bootstrap-ad-rs-for-plutus-apps-as-a-whole branch 3 times, most recently from bfbe5f1 to 9bbf1ab Compare June 12, 2022 00:32
@andreabedini
Copy link
Contributor

andreabedini commented Jun 14, 2022

Is the intention that while working on a feture a developer captures decisions in the doc/adr folder which are then discussed during PR?

Copy link
Contributor

@joseph-fajen joseph-fajen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a number of comments for us to talk about. Interesting stuff!

@koslambrou koslambrou force-pushed the PLT-358-bootstrap-ad-rs-for-plutus-apps-as-a-whole branch 2 times, most recently from 5b40831 to 8f14360 Compare June 15, 2022 18:17
@koslambrou
Copy link
Contributor Author

koslambrou commented Jun 15, 2022

Is the intention that while working on a feture a developer captures decisions in the doc/adr folder which are then discussed during PR?

@andreabedini Very good question, and we need to discuss this. I see multiple options.

  • the person working on a feature has to make a significant design change, then he/she should open an ADR and document the decision
  • the person writes an ADR and waits for approval, then he can make the PR with the feature which references the ADR.
  • the decision can also be documented after the feature has be merged

@koslambrou koslambrou force-pushed the PLT-358-bootstrap-ad-rs-for-plutus-apps-as-a-whole branch 4 times, most recently from abaffbe to f8e1022 Compare June 15, 2022 19:06
@koslambrou koslambrou marked this pull request as ready for review June 21, 2022 18:44
Copy link
Contributor

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@koslambrou koslambrou force-pushed the PLT-358-bootstrap-ad-rs-for-plutus-apps-as-a-whole branch 2 times, most recently from 4fa3647 to 7892bad Compare June 22, 2022 17:04
@koslambrou koslambrou force-pushed the PLT-358-bootstrap-ad-rs-for-plutus-apps-as-a-whole branch from 7892bad to 0aff629 Compare June 23, 2022 13:16
@koslambrou koslambrou merged commit df9ce7d into main Jun 23, 2022
@koslambrou koslambrou deleted the PLT-358-bootstrap-ad-rs-for-plutus-apps-as-a-whole branch June 23, 2022 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants