Skip to content
This repository has been archived by the owner on Dec 2, 2024. It is now read-only.

PureScript Updates #238

Merged
merged 21 commits into from
Jan 24, 2022
Merged

PureScript Updates #238

merged 21 commits into from
Jan 24, 2022

Conversation

jhbertra
Copy link
Contributor

@jhbertra jhbertra commented Jan 11, 2022

Original:

This was an error made when writing the command for buildPursPackage. It should be reading from $src/**/*.purs, not src/**/*.purs, as this gets set when calling this function.

Now:

I've taken the liberty of updating several things regarding the PureScript:

  1. I've fixed the problem mentioned above with buildPursPackage
  2. I've un-gitignored the generated purescript code. This will make it so that Haskell changes that result in generated PureScript changes are always visible in pull requests.
  3. I've also added a CI test to make sure that the generated purescript is up-to-date (a consequence of checking it in is that it needs to be updated when the original Haskell types change).
  4. I've removed purs-loader. It offered no benefit and slowed down / complicated the webpack build significantly. Now it simply bundles the javascript emitted by purs in output.
  5. I've improved a couple things in the nami-demo config.

@jhbertra jhbertra self-assigned this Jan 11, 2022
@jhbertra jhbertra force-pushed the jhbertra/fix-build-purs-package branch 2 times, most recently from 4483279 to 88d3ec7 Compare January 11, 2022 19:45
@jhbertra jhbertra changed the title Use instead of src when building purs in nix Use $src instead of src when building purs in nix Jan 11, 2022
@sjoerdvisscher
Copy link
Contributor

sjoerdvisscher commented Jan 12, 2022

How does this suddenly generate this many errors? Do you need help fixing them?

@jhbertra
Copy link
Contributor Author

@sjoerdvisscher it's complicated, but I fixed it in marlowe-cardano, so I know what needs to be done.

@sjoerdvisscher
Copy link
Contributor

@jhbertra Ok, if this need a lot of boring manual labor let me know.

@jhbertra jhbertra force-pushed the jhbertra/fix-build-purs-package branch from 88d3ec7 to c797581 Compare January 12, 2022 19:30
@jhbertra jhbertra changed the title Use $src instead of src when building purs in nix PureScript Updates Jan 12, 2022
@jhbertra jhbertra requested review from koslambrou, a user and silky January 12, 2022 19:34
Copy link
Contributor

@sjoerdvisscher sjoerdvisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I had no idea we generated such a large amount of code!

@jhbertra jhbertra force-pushed the jhbertra/fix-build-purs-package branch from c797581 to d51db0a Compare January 24, 2022 15:12
@jhbertra jhbertra force-pushed the jhbertra/fix-build-purs-package branch from d51db0a to ccbd931 Compare January 24, 2022 15:13
@jhbertra jhbertra merged commit 8574e96 into main Jan 24, 2022
@jhbertra jhbertra deleted the jhbertra/fix-build-purs-package branch January 24, 2022 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants