-
Notifications
You must be signed in to change notification settings - Fork 33
Ensure mempool always closes stale forkers #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure mempool always closes stale forkers #1738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from updating the PR title/commit message to mention that the core improvement here is that we now actually always close the forker. The fact that we don't open them when not necessary is nice/a great way to ensure this, but not the headline.
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Mempool/Update.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Mempool/Update.hs
Show resolved
Hide resolved
a9b2d6b to
a996bf1
Compare
a996bf1 to
1010e94
Compare
|
I'm actually going to leave out the change of allocating the thread, because we need resource-registry 0.2 and I don't want to update it here too |
6a92cb5 to
1010e94
Compare
1010e94 to
19ff6ac
Compare
95c16e1
A partial backport of #1714.
The forker was being opened always, and in the following situation it will be leaked and block the V1 LedgerDB lock forever: