[WIP] Enrich block bodies to contain Peras certificates #1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid orphans - We actually can't check that the open states are consistent directly as we would need to statefully get that info from the SUT.
It makes sense to use this without using an entire PerasCertDB, so decouple these. It might be nice to rename PerasCertDB-bench, but doesn't seem like a priority.
using cabal-docspec (not yet nixified)
This is purely for concise QuickCheck counterexample output.
This is in preparation for weighted chain comparisons.
Also remove the version for `ValidatedChainDiff` as it is unused.
Brings in cardano-base and propagates a set of `CardanoFeatureFlag`s from the top-level `RunNodeArgs` down to the `NodeKernelArgs`. This is currently needed by an upcoming PR to the GSM to distinguish whether having an established PerasCertDiffusion connection with a given peer is necessary or not when trying to decide if such peer is idling.
Bumps the external ouroboros-network source-repository-package to the updated peras-staging/pr-5202, which incorporates the changes from: IntersectMBO/ouroboros-network#5202 In addition, it tweak call sites of `nodeToNodeProtocols` to match its updated signature, passing down the enabled feature flags.
agustinmista
force-pushed
the
peras/enrich-shelley-blocks-with-certs
branch
from
24dba5c to
13e6fa7
Compare
agustinmista
commented
Oct 17, 2025
ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Block.hs
Show resolved
Hide resolved
agustinmista
commented
Oct 17, 2025
ouroboros-consensus-cardano/src/unstable-shelley-testlib/Test/Consensus/Shelley/Examples.hs
Show resolved
Hide resolved
agustinmista
commented
Oct 17, 2025
ouroboros-consensus-cardano/src/unstable-shelley-testlib/Test/Consensus/Shelley/Examples.hs
Show resolved
Hide resolved
agustinmista
commented
Oct 17, 2025
|
|
||
| instance ShelleyCompatible proto era => Condense (ShelleyBlock proto era) where | ||
| condense = show . shelleyBlockRaw | ||
| condense = show . ((shelleyBlockHeader &&& shelleyBlockBody) &&& shelleyBlockPerasCert) |
Contributor
Author
There was a problem hiding this comment.
We might want to tweak this instance.
agustinmista
force-pushed
the
peras/enrich-shelley-blocks-with-certs
branch
2 times, most recently
from
65b3897 to
a93ba8f
Compare
agustinmista
commented
Oct 20, 2025
ouroboros-consensus/src/unstable-consensus-testlib/Test/Util/Serialisation/Golden.hs
Show resolved
Hide resolved
agustinmista
force-pushed
the
peras/enrich-shelley-blocks-with-certs
branch
from
a93ba8f to
c0822d7
Compare
amesgen
reviewed
Oct 20, 2025
Member
amesgen
left a comment
amesgen
left a comment
There was a problem hiding this comment.
This looks good to me for now, let's wait until we get feedback from Ledger
Comment on lines
+176
to
+187
| -- | Reconstruct a Shelley ledger block from a 'ShelleyBlock'. | ||
| -- | ||
| -- TODO: we should be able to avoid this conversion in most cases | ||
| fromShelleyBlock :: ShelleyBlock proto era -> SL.Block (ShelleyProtocolHeader proto) era | ||
| fromShelleyBlock blk = SL.Block (shelleyBlockHeader blk) (shelleyBlockBody blk) | ||
|
|
||
| -- | Construct a 'ShelleyBlock' from a Shelley ledger block. | ||
| -- | ||
| -- TODO: we should be able to avoid this conversion in most cases | ||
| toShelleyBlock :: | ||
| ShelleyCompatible proto era => SL.Block (ShelleyProtocolHeader proto) era -> ShelleyBlock proto era | ||
| toShelleyBlock (SL.Block hdr body) = mkShelleyBlock hdr body |
Member
There was a problem hiding this comment.
We could also just store an SL.Block, but encode it differently. But either way, this conversion should be super cheap
ouroboros-consensus-cardano/src/unstable-shelley-testlib/Test/Consensus/Shelley/Examples.hs
Show resolved
Hide resolved
agustinmista
force-pushed
the
peras-staging
branch
from
a97ac93 to
eef954f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes tweag/cardano-peras#141