Add some details on the expected file formats #1662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly
requested review from
amesgen,
dnadales,
fraser-iohk,
geo2a,
jasagredo and
nfrisby
as code owners
Contributor
Author
jasagredo
approved these changes
Sep 3, 2025
Contributor
jasagredo
left a comment
jasagredo
left a comment
There was a problem hiding this comment.
I was going to mention that it might be better to edit the Readme instead, but the readme explicitly says to run the tool without arguments to see the usage instructions. Therefore I am ok with this change.
Contributor
|
I can't push to the branch in your fork for fixing the fourmolu format. Would you do it and then we can merge @abailly ? |
Contributor
Author
|
@jasagredo yes, my bad, I did not pay attention to the formatting. Will do it later today |
abailly
force-pushed
the
abailly/document-db-synthesizer
branch
from
454344b to
6ff2c09
Compare
Contributor
Author
|
Ping @jasagredo ! Looks good now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny PR documents in a bit more details how the arguments to
db-synthesizerprogram look like. In particular, it wasn't obvious what the "bulk credentials" structure was and I got it only after looking at the example. HTH.