Fix encoding of WithOrigin in TPraosState
#1535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
amesgen,
dnadales,
fraser-iohk,
geo2a,
jorisdral and
nfrisby
as code owners
amesgen
approved these changes
May 28, 2025
|
Ah lol the decoder should also be fixed 😅 |
|
Ah of course haha |
jasagredo
force-pushed
the
js/withoriginth
branch
from
eaea1cd to
6fc20f0
Compare
jasagredo
added a commit
that referenced
this pull request
Sep 18, 2025
This was removed in #1535 but we forgot to update the spec.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 20, 2025
This was removed in #1535 but we forgot to update the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the only place I identified where we used the derived encoding. It only affects ledger states pre-Babbage.
Closes #1531