KES agent integration #1487
Closed
KES agent integration #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
commented
Apr 30, 2025
ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Node/TPraos.hs
Outdated
Show resolved
Hide resolved
...os-consensus-diffusion/src/ouroboros-consensus-diffusion/Ouroboros/Consensus/Node/Tracers.hs
Show resolved
Hide resolved
...-protocol/src/ouroboros-consensus-protocol/Ouroboros/Consensus/Protocol/Praos/AgentClient.hs
Outdated
Show resolved
Hide resolved
...ensus-protocol/src/ouroboros-consensus-protocol/Ouroboros/Consensus/Protocol/Praos/Common.hs
Outdated
Show resolved
Hide resolved
...consensus/src/ouroboros-consensus/Ouroboros/Consensus/MiniProtocol/ChainSync/Client/State.hs
Outdated
Show resolved
Hide resolved
jasagredo
force-pushed
the
js/tdammers/kes-agent-conectivity
branch
from
a10939e to
1cf35e6
Compare
jasagredo
commented
Apr 30, 2025
ouroboros-consensus-cardano/src/unstable-shelley-testlib/Test/Consensus/Shelley/MockCrypto.hs
Outdated
Show resolved
Hide resolved
jasagredo
force-pushed
the
js/tdammers/kes-agent-conectivity
branch
from
ceb0550 to
4ca03a3
Compare
jasagredo
force-pushed
the
js/tdammers/kes-agent-conectivity
branch
from
108bfcb to
833650d
Compare
jasagredo
force-pushed
the
js/tdammers/kes-agent-conectivity
branch
from
833650d to
4828699
Compare
jasagredo
requested review from
amesgen,
dnadales,
fraser-iohk,
geo2a,
jorisdral and
nfrisby
as code owners
tdammers
requested changes
May 15, 2025
Comment on lines
+190
to
+191
| vrfKey <- genKeyVRF <$> genSeed (seedSizeVRF (Proxy @(VRF c))) | ||
| kesKey <- unsoundPureGenKeyKES <$> genSeed (seedSizeKES (Proxy @(KES c))) |
Comment on lines
+14
to
+18
| specifies how to obtain the actual credentials (OpCert and KES SignKey). For | ||
| now, the only supported method is passing an OpCert and an | ||
| UnsoundPureSignKeyKES, presumably loaded from disk | ||
| (`PraosCredentialsUnsound`); future iterations will add support for | ||
| connecting to a KES agent. |
There was a problem hiding this comment.
Suggested change
| specifies how to obtain the actual credentials (OpCert and KES SignKey). For | |
| now, the only supported method is passing an OpCert and an | |
| UnsoundPureSignKeyKES, presumably loaded from disk | |
| (`PraosCredentialsUnsound`); future iterations will add support for | |
| connecting to a KES agent. | |
| specifies how to obtain the actual credentials (OpCert and KES SignKey). | |
| Two methods are supported: | |
| - Directly passing an OpCert and an UnsoundPureSignKeyKES, presumably loaded | |
| from disk (`PraosCredentialsUnsound`) | |
| - Passing a socket address to a KES Agent from which OpCerts and (sound) | |
| SignKeyKES can be obtained (`PraosCredentialsAgent`) |
ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Node/TPraos.hs
Outdated
Show resolved
Hide resolved
fraser-iohk
force-pushed
the
js/tdammers/kes-agent-conectivity
branch
from
4208ea1 to
3228821
Compare
fraser-iohk
force-pushed
the
js/tdammers/kes-agent-conectivity
branch
from
6c5adc4 to
3228821
Compare
|
This PR has been superceded by #1620 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
This PR supercedes #1487 includes the following squashed commit messages: - Update to use newest cardano-crypto-class with unsound pure KES implementation - Use mlocked KES - Add KES agent connectivity - Rebase cleanup - Handle drop-key messages from KES Agent - Provide KESAgentClientTrace to BlockForging - Revert change to MockCrypto and require DSIGN only when running the KES agent - Bump kes-agent SRP to remove SerDoc dependency # Description Please include a meaningful description of the PR and link the relevant issues this PR might resolve. Also note that: - New code should be properly tested (even if it does not add new features). - The fix for a regression should include a test that reproduces said regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes Consensus such that mlocked KES keys are used internally.
This is important groundwork for supporting KES agents in the future. In this form, the code will still load KES keys from disk, which is unsound, but the internal machinery is ready to also accept KES keys from other sources, and once loaded, KES keys will be handled appropriately (kept in mlocked RAM at all times, securely erased when expired).
This also involves a restructuring of the
HotKeydata structure, which now manages not only a KES SignKey, but also the corresponding OpCert. This is necessary for two reasons:Supersedes #1284.
Issue #558.
This adds KES Agent connectivity to consensus.
To use a KES Agent to source KES SignKeys and OpCerts, the
praosCredentialsSourcein thePraosCanBeLeaderdata structure can now be pointed to a domain socket address where it will look for a KES Agent.Also covers #1077.