Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out duplicate collateral inputs in transaction build #4745

Closed

Conversation

nielstron
Copy link
Contributor

This fixes #4744 and potential further issues resulting from unfiltered duplicate collateral inputs.

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! One comment.

cardano-cli/src/Cardano/CLI/Shelley/Run/Transaction.hs Outdated Show resolved Hide resolved
@nielstron nielstron force-pushed the fix/filter-collateral-inputs branch from 6a10c10 to b5691ca Compare January 3, 2023 20:47
@Jimbo4350
Copy link
Contributor

Subsumed by #4749

@Jimbo4350 Jimbo4350 closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Cardano-cli computes wrong collateral return output for multiple occurrences of collateral inputs
2 participants