Skip to content

Conversation

@TimSheard
Copy link
Contributor

@TimSheard TimSheard commented Jul 18, 2025

Get all tests to pass without the UMap

Fixes #5177

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@TimSheard TimSheard requested a review from a team as a code owner July 18, 2025 15:58
@lehins lehins changed the title Lehins/era specific umap tim sheard adjustments Fix for CERTS constraint generators Jul 18, 2025
@lehins lehins force-pushed the lehins/era-specific-umap-tim-sheard-adjustments branch from 8775bb7 to 56f8d9a Compare July 19, 2025 00:47
@lehins lehins force-pushed the lehins/era-specific-umap-tim-sheard-adjustments branch from 56f8d9a to 28d376f Compare July 19, 2025 02:01
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your help, Tim!
I've cleaned this PR up just little a bit and prepared it for the merge

@TimSheard TimSheard merged commit 8b1f7a1 into master Jul 20, 2025
128 checks passed
@TimSheard TimSheard deleted the lehins/era-specific-umap-tim-sheard-adjustments branch July 20, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix CERTS conformance test

3 participants