-
Notifications
You must be signed in to change notification settings - Fork 166
Replace PPViewHashesDontMatch with ScriptIntegrityHashMismatch starting from PV 11
#5172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PPViewHashesDontMatch predicate failure to ConwayPPViewHashesDontMatch predicate failure to Conway
6ca8034 to
d3b33ca
Compare
PPViewHashesDontMatch predicate failure to ConwayPPViewHashesDontMatch with ScriptIntegrityHashMismatch starting from PV 11
597064e to
cbc948b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the idea is the right one, but there is a problem with reporting the bytes, since they can be SNothing.
Also by doing this implementation in Alonzo era, we'll be able to simplify it after the hard fork and just pretend like it was always done this way.
eras/conway/impl/testlib/Test/Cardano/Ledger/Conway/Imp/UtxowSpec.hs
Outdated
Show resolved
Hide resolved
c5f21b8 to
91fc55c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Except there is a slight performance regression which needs a fix.
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/Updaters.hs
Outdated
Show resolved
Hide resolved
82eeaf9 to
0e05796
Compare
812d2a4 to
35f22c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice improvement! Thank you!
Only some minor suggestions about naming, changelogs and such
eras/alonzo/test-suite/src/Test/Cardano/Ledger/Alonzo/AlonzoEraGen.hs
Outdated
Show resolved
Hide resolved
ae44196 to
52739e9
Compare
Co-authored-by: Alexey Kuleshevich <[email protected]>
52739e9 to
a9b87ed
Compare
Description
This PR adds a new
ScriptIntegrityHashMismatchpredicate failure to Conway'sUTXOWrule. The new predicate failure is similar to the oldPPViewHashesDontMatchfailure, but it also contains the bytestring that was hashed by the node in order to compute the script integrity hash. This new predicate failure will be thrown instead of the old one starting from protocol version 11.close #4517
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changes.NOTE: New section is never added with the code changes. (See RELEASING.md).
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessary.NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
scripts/fourmolize.sh).scripts/cabal-format.sh).scripts/gen-cddl.sh)hie.yamlupdated (usescripts/gen-hie.sh).