Made MEMPOOL call LEDGER #4880
Open
Made MEMPOOL call LEDGER #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/invert-mempool
branch
from
b71a576 to
45c690e
Compare
Soupstraw
force-pushed
the
jj/invert-mempool
branch
from
45c690e to
afba950
Compare
Soupstraw
commented
Feb 10, 2025
| @@ -84,7 +84,6 @@ instance RuleListEra ConwayEra where | |||
| , "GOV" | |||
| , "LEDGER" | |||
| , "LEDGERS" | |||
| , "MEMPOOL" | |||
There was a problem hiding this comment.
If I leave this here, I get a compiler error that says that it can't find an EraRuleFailure instance for the MEMPOOL predicate failures. However I can't add EraRuleFailure type instance for MEMPOOL because that violates type injectivity since MEMPOOL shares the predicate failure with LEDGER.
Soupstraw
force-pushed
the
jj/invert-mempool
branch
from
c9901fd to
fb73f98
Compare
Soupstraw
force-pushed
the
jj/invert-mempool
branch
from
fb73f98 to
02dba29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #4864
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changesNew section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessaryIf you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
scripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlupdated (usescripts/gen-hie.sh)