Skip to content

Commit

Permalink
Remove RatifySpec test with unclear purpose
Browse files Browse the repository at this point in the history
The test seems to check that NoConfidence and CommitteUpdate govActions
are enacted during bootstrap period, but the test cannot run during
bootstrap, because these actions are not allowed.
  • Loading branch information
teodanciu authored and Lucsanszky committed Oct 29, 2024
1 parent 664dd7b commit c051f13
Showing 1 changed file with 0 additions and 41 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ spec = do
relevantDuringBootstrapSpec
votingSpec
delayingActionsSpec
spoVotesCommitteeUpdates
committeeMinSizeAffectsInFlightProposalsSpec
paramChangeAffectsProposalsSpec
committeeExpiryResignationDiscountSpec
Expand Down Expand Up @@ -517,46 +516,6 @@ committeeMinSizeAffectsInFlightProposalsSpec =
passNEpochs 2
getsNES (nesEsL . esAccountStateL . asTreasuryL) `shouldReturn` (treasury <-> amount)

spoVotesCommitteeUpdates ::
forall era.
ConwayEraImp era =>
SpecWith (ImpTestState era)
spoVotesCommitteeUpdates =
describe "Counting of SPO votes" $ do
describe "All gov action other than HardForkInitiation" $ do
it "NoConfidence" $ do
(spoK1, _, _) <- setupPoolWithStake $ Coin 100_000_000
_ <- setupPoolWithStake $ Coin 100_000_000
_ <- setupPoolWithStake $ Coin 100_000_000
_ <- setupPoolWithStake $ Coin 100_000_000
modifyPParams $ ppPoolVotingThresholdsL . pvtMotionNoConfidenceL .~ 1 %! 2
whenPostBootstrap (modifyPParams $ ppDRepVotingThresholdsL .~ def)
gai <- submitGovAction $ NoConfidence SNothing
-- bootstrap: 1 % 4 stake yes; 3 % 4 stake abstain; yes / stake - abstain > 1 % 2
-- post-bootstrap: 1 % 4 stake yes; 3 % 4 stake no; yes stake < 1 % 2
submitYesVote_ (StakePoolVoter spoK1) gai
passNEpochs 2
pv <- getProtVer
if bootstrapPhase pv
then getLastEnactedCommittee `shouldReturn` SJust (GovPurposeId gai)
else getLastEnactedCommittee `shouldReturn` SNothing
it "CommitteeUpdate" $ do
(spoK1, _, _) <- setupPoolWithStake $ Coin 100_000_000
_ <- setupPoolWithStake $ Coin 100_000_000
_ <- setupPoolWithStake $ Coin 100_000_000
_ <- setupPoolWithStake $ Coin 100_000_000
modifyPParams $ ppPoolVotingThresholdsL . pvtCommitteeNormalL .~ 1 %! 2
whenPostBootstrap (modifyPParams $ ppDRepVotingThresholdsL .~ def)
cc <- KeyHashObj <$> freshKeyHash
gai <- submitUpdateCommittee Nothing mempty [(cc, EpochInterval 5)] (1 %! 2)
-- bootstrap: 1 % 4 stake yes; 3 % 4 stake abstain; yes / stake - abstain > 1 % 2
-- post-bootstrap: 1 % 4 stake yes; 3 % 4 stake no; yes stake < 1 % 2
submitYesVote_ (StakePoolVoter spoK1) gai
passNEpochs 2
pv <- getProtVer
if bootstrapPhase pv
then getLastEnactedCommittee `shouldReturn` SJust (GovPurposeId gai)
else getLastEnactedCommittee `shouldReturn` SNothing
spoVotesForHardForkInitiation ::
forall era.
ConwayEraImp era =>
Expand Down

0 comments on commit c051f13

Please sign in to comment.