Skip to content

Deprecate certificate #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Deprecate certificate #1280

wants to merge 2 commits into from

Conversation

@palas
Copy link
Contributor

@palas palas commented Sep 16, 2025

Changelog

- description: |
    Replace usages of old `Certificate` for the one in experimental API
  type:
  - compatible     # the API has changed but is non-breaking

Context

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Jimbo4350 and others added 2 commits September 16, 2025 21:21
@Jimbo4350 @palas
Deprecate certificate
620db1b 
- Remove usage (as much as possible) of the "old" api's Certificate type
- Update golden files
@palas
Use new Certificate format everywhere but in compatible commands
526278e
@palas palas self-assigned this Sep 16, 2025
@palas palas changed the base branch from master to bump-cardano-api-10.18.0.0 September 16, 2025 19:47
Base automatically changed from bump-cardano-api-10.18.0.0 to master September 16, 2025 23:08
@palas palas assigned Jimbo4350 and unassigned palas Sep 17, 2025
@palas palas linked an issue Sep 17, 2025 that may be closed by this pull request
Deprecate old Certificate type #1281
Open
@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Sep 23, 2025

Subsumed by #1278

@Jimbo4350 Jimbo4350 closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 will be requested when the pull request is marked ready for review Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy will be requested when the pull request is marked ready for review newhoggy is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer will be requested when the pull request is marked ready for review carbolymer is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond will be requested when the pull request is marked ready for review kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler will be requested when the pull request is marked ready for review disassembler is a code owner

Assignees

@Jimbo4350 Jimbo4350

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate old Certificate type

3 participants

@palas @Jimbo4350