Modify proto-to-js.nix to bundle all proto files
#913
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
The PR #911 made it easy to generate a JS from the
node.protofile, but it was only generating it for that file (node_grpc_web_pb.js). And there are more.protofiles in theprotofolder. This PR modifies it to generate bundle files for all the.protofiles in theprotofolder. This PR also uses the opportunity to quote some of the shell variables, so that they work even if they have spaces on them.How to trust this PR
I tested that it works. I would check that there are no edge cases and that the code style is good.
Checklist