Skip to content

Conversation

@palas
Copy link
Contributor

@palas palas commented Jul 23, 2025

Changelog

- description: |
    Update `proto-js-bundle` nix output to create bundles for all the `.proto` files
  type:
  - feature
  projects:
  - cardano-rpc

Context

The PR #911 made it easy to generate a JS from the node.proto file, but it was only generating it for that file (node_grpc_web_pb.js). And there are more .proto files in the proto folder. This PR modifies it to generate bundle files for all the .proto files in the proto folder. This PR also uses the opportunity to quote some of the shell variables, so that they work even if they have spaces on them.

How to trust this PR

I tested that it works. I would check that there are no edge cases and that the code style is good.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas self-assigned this Jul 23, 2025
@palas palas requested a review from a team as a code owner July 23, 2025 19:31
@palas palas changed the title Modify proto-to-js.nix to bundle all proto files Modify proto-to-js.nix to bundle **all** proto files Jul 23, 2025
@palas palas changed the title Modify proto-to-js.nix to bundle **all** proto files Modify proto-to-js.nix to bundle *al** proto files Jul 23, 2025
@palas palas changed the title Modify proto-to-js.nix to bundle *al** proto files Modify proto-to-js.nix to bundle *all* proto files Jul 23, 2025
@palas palas changed the title Modify proto-to-js.nix to bundle *all* proto files Modify proto-to-js.nix to bundle _all_ proto files Jul 23, 2025
@palas palas changed the title Modify proto-to-js.nix to bundle _all_ proto files Modify proto-to-js.nix to bundle all proto files Jul 23, 2025
@palas palas added this pull request to the merge queue Jul 24, 2025
Merged via the queue into master with commit 7d38341 Jul 24, 2025
35 checks passed
@palas palas deleted the add-all-proto-files-to-nix-output branch July 24, 2025 11:18
@palas palas mentioned this pull request Jul 24, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants