-
Notifications
You must be signed in to change notification settings - Fork 25
Add typescript declarations for cardano-wasm API and generate it automatically from ApiInfo
#901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
166c823 to
7c9eb4c
Compare
62e88cb to
c21e28a
Compare
carbolymer
reviewed
Jul 15, 2025
carbolymer
reviewed
Jul 15, 2025
carbolymer
reviewed
Jul 15, 2025
carbolymer
reviewed
Jul 15, 2025
carbolymer
reviewed
Jul 15, 2025
78690aa to
69d5af6
Compare
2cc682c to
c84ad5b
Compare
c84ad5b to
8d2423f
Compare
8d2423f to
d4a5e5b
Compare
carbolymer
reviewed
Jul 18, 2025
carbolymer
reviewed
Jul 18, 2025
carbolymer
reviewed
Jul 18, 2025
carbolymer
approved these changes
Jul 18, 2025
Jimbo4350
approved these changes
Jul 18, 2025
Co-authored-by: Mateusz Galazyn <[email protected]>
Co-authored-by: Mateusz Galazyn <[email protected]>
9556681 to
50928d4
Compare
50928d4 to
bb53acb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Because JavaScript is untyped, this PR adds TypeScript declarations that both help users of
cardano-wasmAPI to get types right, and also they will get detailed contextual documentation when using it from IDEs.How to trust this PR
What I checked is that the generated
d.tsfile is the same as the manually written one (pretty much). I also checked that you can use it from VSCode and get autocompletion and contextual documentation.I would check the style and that there are no bugs. You can also try running the
.d.tsgeneration (which is the main executable ofcardano-wasm)Checklist