Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace triangular loader with blue circular spinner #922

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

abansal15
Copy link
Contributor

Description

Replaced the default triangular loader in PrefixHegemonyChart.vue and CountryHegemonyTable.vue with the blue circular spinner to maintain UI consistency across the site. Updated the corresponding CSS and markup without affecting functionality.

Related issue

#921

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dpgiakatos dpgiakatos self-requested a review March 3, 2025 03:01
Copy link
Member

@dpgiakatos dpgiakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not solve the corresponding issue; instead, it creates another issue. There are two loading effects in the modified components, and the spinner is not aligned with the position of the other loading components. Therefore, this PR should not be merged.

@dpgiakatos
Copy link
Member

Please ensure that you have tested the changes before requesting a review.
Thanks.

@abansal15
Copy link
Contributor Author

abansal15 commented Mar 3, 2025

Hello @dpgiakatos can you please review it hopefully issue has solved now and sorry for the mistake i have done and will take care of it in the future .. actually i forgot to remove the Horizontal moving line which is along with Triangular loader causing multiple loading effect.. and also made the spinner at center

image

please see this image now spinner is at center and there is no Horizontal moving line..

@abansal15
Copy link
Contributor Author

abansal15 commented Mar 3, 2025

Also i have changed the equality check from == to === in the expression
return row.asn_name === '' ? '--' : row.asn_name
to enforce strict comparison. If you'd prefer to revert this change, please let me know.

Copy link
Member

@dpgiakatos dpgiakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dpgiakatos dpgiakatos merged commit f198cd9 into InternetHealthReport:master Mar 3, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants