Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disbaled Searchbar when map overlay is open #919

Merged

Conversation

sahitya-chandra
Copy link
Contributor

@sahitya-chandra sahitya-chandra commented Feb 27, 2025

Description

Made the search bar disabled when the map overlay is open.
added a state variable isSearchBarDisabled to control the search bar.

Related issue

fixed #916

How Has This Been Tested?

I have tested all the changes locally

Screenshots (if appropriate):

Screencast.from.2025-02-27.08-47-03.webm

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sahitya-chandra
Copy link
Contributor Author

Sir please review this code...

@dpgiakatos dpgiakatos self-requested a review February 27, 2025 04:10
Copy link
Member

@dpgiakatos dpgiakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dpgiakatos dpgiakatos merged commit 604ebf4 into InternetHealthReport:master Feb 27, 2025
5 of 6 checks passed
@sahitya-chandra sahitya-chandra deleted the 916-disable-searchbar branch February 27, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search bar still takes input and works in background even after map overlay is open
2 participants