fix: Fixed the hiding behavior of sidebar with footer in Documentation.vue #909
Conversation
|
@dpgiakatos Sir please review this code... |
sahitya-chandra
changed the title
There was a problem hiding this comment.
This PR deletes the QDrawer and re-implements it. However, the contributor should have used the existing QDrawer and fixed the issue instead of deleting and re-implementing it. We don't need to reinvent the wheel, as this approach will take too much time for maintenance. Thus, this PR needs a lot of changes and should continue to use Quasar components.
|
@dpgiakatos Sir Due to the implicit behavior of QDrawer it has infinite height because of this I have re-implemented the sidebar for static behavior. |
|
Yes, you can use other quasar components. |
|
@dpgiakatos Sir I have added the QSplitter component and organized the CSS in proper order. Removed multiple media-query. Screencast.from.2025-02-18.11-15-30.webm |
|
Also Sir, I have not deleted much code just organised it. |
There was a problem hiding this comment.
Address my inline comment. Additionally, I would like the page to have the same behavior as the old version. Previously, when scrolling to a section, the contents would be visible on the right. In this version, you have to scroll to the top to see them. I would like to restore the same behavior as the old page, where the contents are visible on the right when scrolling to a section.
src/views/Documentation.vue
Outdated
| <div v-for="(sec, idx) in sections" :key="idx"> | ||
| <div class="text-weight-light"> | ||
| {{ $t(`documentationPage.sectionsTitle.${sec.sectionsTitle}`) }} | ||
| <QSplitter> |
There was a problem hiding this comment.
You haven't configured the component. You have to ad the v-model.
Also, add disable property.
Read the documentation:
https://quasar.dev/vue-components/splitter
There was a problem hiding this comment.
@dpgiakatos Sir as you mentioned above to achieve old version behavior.
I have removed the QSplitter component because it was causing problems with anchor navigation and
I have added QCard and QCardSection for proper navigation and better scrolling of Sidebar.
|
This the current behavior after last commit. Screencast.from.2025-02-18.18-54-19.webm |
|
Sir I have also removed multiple media queries to reduce redundancy in the code. |
|
Thanks for approving my changes Sir...🚀 |
Description
Related issue
fixed #908
How Has This Been Tested?
I have tested all the changes locally.
Screenshots (if appropriate):
Screencast.from.2025-02-17.15-21-42.webm
Screencast.from.2025-02-17.16-14-06.webm
Types of changes
Checklist: