Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove logitswarper #3109

Merged
merged 1 commit into from
Feb 6, 2025
Merged

remove logitswarper #3109

merged 1 commit into from
Feb 6, 2025

Conversation

grimoire
Copy link
Collaborator

@grimoire grimoire commented Feb 6, 2025

Latest transformers has removed logitswarper

@lvhan028 lvhan028 requested a review from AllentDan February 6, 2025 03:59
@lvhan028
Copy link
Collaborator

lvhan028 commented Feb 6, 2025

Does it affect the customized logits processor function?

@grimoire
Copy link
Collaborator Author

grimoire commented Feb 6, 2025

custom logits is treated as function call.

Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028
Copy link
Collaborator

lvhan028 commented Feb 6, 2025

Does it work for lower-version transformers?

@grimoire
Copy link
Collaborator Author

grimoire commented Feb 6, 2025

Does it work for lower-version transformers?

Yes

@lvhan028 lvhan028 merged commit a8fac20 into InternLM:main Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants