Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support internlm3 on pt #3026

Merged
merged 2 commits into from
Jan 14, 2025
Merged

support internlm3 on pt #3026

merged 2 commits into from
Jan 14, 2025

Conversation

RunningLeon
Copy link
Collaborator

Motivation

support internlm/internlm3-8b-instruct

Modification

BC-breaking (Optional)

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lvhan028 lvhan028 added the enhancement New feature or request label Jan 14, 2025
AllentDan
AllentDan approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028
Copy link
Collaborator

May resolve the conflict

lvhan028
lvhan028 reviewed Jan 14, 2025
View reviewed changes
lmdeploy/model.py Outdated Show resolved Hide resolved
@lvhan028 lvhan028 merged commit aa40f0b into InternLM:main Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvhan028 lvhan028 lvhan028 left review comments

@grimoire grimoire grimoire approved these changes

@AllentDan AllentDan AllentDan approved these changes

@zhyncs zhyncs zhyncs approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RunningLeon @lvhan028 @grimoire @AllentDan @zhyncs