Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove decoding #3016

Merged
merged 2 commits into from
Jan 14, 2025
Merged

remove decoding #3016

merged 2 commits into from
Jan 14, 2025

Conversation

grimoire
Copy link
Collaborator

@grimoire grimoire commented Jan 13, 2025 •
edited by lvhan028
Loading

RunningLeon
RunningLeon approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK with llama3 with output_logits in pipeline

RunningLeon
RunningLeon approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 46aa4e5 into InternLM:main Jan 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvhan028 lvhan028 lvhan028 approved these changes

@RunningLeon RunningLeon RunningLeon approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grimoire @lvhan028 @RunningLeon