Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix xcomposer2 when transformers is upgraded greater than 4.46 #3001

Merged
merged 1 commit into from
Jan 11, 2025
Merged

fix xcomposer2 when transformers is upgraded greater than 4.46 #3001

merged 1 commit into from
Jan 11, 2025

Conversation

irexyc
Copy link
Collaborator

@irexyc irexyc commented Jan 8, 2025

@lvhan028 lvhan028 added the Bug:P1 label Jan 9, 2025
@lvhan028 lvhan028 requested a review from AllentDan January 10, 2025 05:35
AllentDan
AllentDan approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK with transformers 4.47.0

@lvhan028 lvhan028 changed the title fix xcomposer2 fix xcomposer2 when transformers is upgraded greater than 4.46 Jan 11, 2025
@lvhan028 lvhan028 merged commit a6d4b4a into InternLM:main Jan 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllentDan AllentDan AllentDan approved these changes

Assignees
No one assigned
Labels
Bug:P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irexyc @AllentDan @lvhan028