Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[side-effect] fix gradio demo error #2976

Merged
merged 1 commit into from
Dec 30, 2024
Merged

[side-effect] fix gradio demo error #2976

merged 1 commit into from
Dec 30, 2024

Conversation

lvhan028
Copy link
Collaborator

@lvhan028 lvhan028 commented Dec 30, 2024 •
edited
Loading

Fix #2974 which is a side effect cause by #2810

@lvhan028 lvhan028 mentioned this pull request Dec 30, 2024
Closed
3 tasks
AllentDan
AllentDan approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit b7a56c7 into InternLM:main Dec 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irexyc irexyc irexyc approved these changes

@AllentDan AllentDan AllentDan approved these changes

@zhulinJulia24 zhulinJulia24 Awaiting requested review from zhulinJulia24

Assignees
No one assigned
Labels
Bug:P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] chat with gradio with mllm models, 'VLAsyncEngine' object has no attribute 'vl_prompt_template'
3 participants
@lvhan028 @irexyc @AllentDan