Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build crash #2964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix build crash #2964

wants to merge 1 commit into from

Conversation

zgjja
Copy link

@zgjja zgjja commented Dec 27, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix 2 bugs

Modification

See #2963

BC-breaking (Optional)

None

Use cases (Optional)

None

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zgjja zgjja marked this pull request as ready for review December 27, 2024 07:00
@lvhan028 lvhan028 requested a review from lzhangzz December 27, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants