Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incorrect stats size during inference of throughput benchmark when concurrency > num_prompts #2928

Merged
merged 2 commits into from
Dec 19, 2024
Merged

fix: Incorrect stats size during inference of throughput benchmark when concurrency > num_prompts #2928

merged 2 commits into from
Dec 19, 2024

Conversation

pancak3
Copy link
Contributor

@pancak3 pancak3 commented Dec 19, 2024

Motivation

Resolve #2927

Modification

Set concurrency to num of requests when the later is smaller.

@lvhan028 lvhan028 requested a review from grimoire December 19, 2024 09:31
grimoire
grimoire approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lvhan028 lvhan028 changed the title fix: issue#2927 fix: Incorrect stats size during inference of throughput benchmark when concurrency > num_prompts Dec 19, 2024
@lvhan028
Copy link
Collaborator

Thanks so much for your contribution

@lvhan028 lvhan028 merged commit 0ffac7f into InternLM:main Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grimoire grimoire grimoire approved these changes

Assignees
No one assigned
Labels
Bug:P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Incorrect stats size during inference of throughput benchmark
3 participants
@pancak3 @lvhan028 @grimoire