Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ascend] convert kv cache to nd format in ascend graph mode #2853

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

tangzhiyi11
Copy link
Contributor

@tangzhiyi11 tangzhiyi11 commented Dec 4, 2024

#2814 changed the kv cache layout on ascend graph, we revert it to nd format in this PR

Motivation

convert kv cache to nd format in ascend graph mode

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@tangzhiyi11 tangzhiyi11 force-pushed the tzy/fix_kv_cache_in_graph branch from dd36934 to 0d99e4b Compare December 4, 2024 06:45
@jinminxi104 jinminxi104 changed the title convert kv cache to nd format in ascend graph mode [ascend] convert kv cache to nd format in ascend graph mode Dec 4, 2024
@lvhan028 lvhan028 added the Bug:P1 label Dec 4, 2024
@lvhan028 lvhan028 merged commit 9bfdeae into InternLM:main Dec 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants