Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix accessing before initialization #2845

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix accessing before initialization #2845

merged 2 commits into from
Dec 2, 2024

Conversation

lvhan028
Copy link
Collaborator

@lvhan028 lvhan028 commented Dec 2, 2024

Fix #2841

@lvhan028 lvhan028 added the Bug:P1 label Dec 2, 2024
@lvhan028 lvhan028 force-pushed the fix-internlm-xcomposer2 branch from dd840e0 to a3f3afe Compare December 2, 2024 07:12
@lvhan028 lvhan028 mentioned this pull request Dec 2, 2024
Closed
3 tasks
zhulinJulia24
zhulinJulia24 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@zhulinJulia24 zhulinJulia24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual test passed

@lvhan028 lvhan028 merged commit c158d18 into InternLM:main Dec 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzhangzz lzhangzz lzhangzz approved these changes

@zhulinJulia24 zhulinJulia24 zhulinJulia24 approved these changes

Assignees
No one assigned
Labels
Bug:P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] cannot chat with internlm-xcomposer2d5-7b and internlm-xcomposer2-4khd-7b with main code
3 participants
@lvhan028 @lzhangzz @zhulinJulia24