-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] support minicpm-v_2_6 for pytorch engine. #2767
Conversation
cc @grimoire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -72,6 +72,7 @@ The TurboMind engine doesn't support window attention. Therefore, for models tha | |||
| DeepSeek-MoE | 16B | LLM | Yes | No | No | No | No | | |||
| DeepSeek-V2 | 16B, 236B | LLM | Yes | No | No | No | No | | |||
| MiniCPM3 | 4B | LLM | Yes | Yes | Yes | No | No | | |||
| MiniCPM-V-2_6 | 8B | LLM | Yes | No | No | No | No | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WaA16 was supported in my testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
93a9a16
to
d6adca4
Compare
d6adca4
to
a31390c
Compare
@@ -72,6 +72,7 @@ The TurboMind engine doesn't support window attention. Therefore, for models tha | |||
| DeepSeek-MoE | 16B | LLM | Yes | No | No | No | No | | |||
| DeepSeek-V2 | 16B, 236B | LLM | Yes | No | No | No | No | | |||
| MiniCPM3 | 4B | LLM | Yes | Yes | Yes | No | No | | |||
| MiniCPM-V-2_6 | 8B | LLM | Yes | No | No | No | Yes | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could update supported_models in readme as well
https://github.com/InternLM/lmdeploy?tab=readme-ov-file#supported-models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MiniCPM-V-2_6 already exists in README, because turbomind engine supported it before, and support list in the README does not distinguish between the turbomind and pytorch engine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
support minicpm-v_2_6 model for pytorch engine.
Modification