Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] support minicpm-v_2_6 for pytorch engine. #2767

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

Reinerzhou
Copy link
Contributor

Motivation

support minicpm-v_2_6 model for pytorch engine.

Modification

  • add minicpm-v_2_6 model file and map.
  • update related readme file.

@lvhan028
Copy link
Collaborator

cc @grimoire

@lvhan028 lvhan028 added the enhancement New feature or request label Nov 19, 2024
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -72,6 +72,7 @@ The TurboMind engine doesn't support window attention. Therefore, for models tha
| DeepSeek-MoE | 16B | LLM | Yes | No | No | No | No |
| DeepSeek-V2 | 16B, 236B | LLM | Yes | No | No | No | No |
| MiniCPM3 | 4B | LLM | Yes | Yes | Yes | No | No |
| MiniCPM-V-2_6 | 8B | LLM | Yes | No | No | No | No |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WaA16 was supported in my testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@Reinerzhou
Copy link
Contributor Author

Reinerzhou commented Nov 20, 2024

@@ -72,6 +72,7 @@ The TurboMind engine doesn't support window attention. Therefore, for models tha
| DeepSeek-MoE | 16B | LLM | Yes | No | No | No | No |
| DeepSeek-V2 | 16B, 236B | LLM | Yes | No | No | No | No |
| MiniCPM3 | 4B | LLM | Yes | Yes | Yes | No | No |
| MiniCPM-V-2_6 | 8B | LLM | Yes | No | No | No | Yes |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MiniCPM-V-2_6 already exists in README, because turbomind engine supported it before, and support list in the README does not distinguish between the turbomind and pytorch engine.

@Reinerzhou Reinerzhou changed the title [Feature] support minicpm-v_2_6. [Feature] support minicpm-v_2_6 for pytorch engine. Nov 21, 2024
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 324237b into InternLM:main Nov 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants