Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ascend]feat: support kv int8 #2736

Merged
merged 9 commits into from
Dec 6, 2024
Merged

Conversation

yao-fengchen
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

This PR support kv int8 on ascend device.

Modification

This PR modified some paras in CacheEngine, context in model_forward,and op_backend of ascend.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@yao-fengchen yao-fengchen marked this pull request as ready for review November 13, 2024 06:49
@lvhan028 lvhan028 added the enhancement New feature or request label Nov 13, 2024
Copy link
Collaborator

@jinminxi104 jinminxi104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will update docs for this pr in another pr

@grimoire
Copy link
Collaborator

grimoire commented Dec 3, 2024

what is ASCEND_QUANT_RECORD_FILE

@lvhan028
Copy link
Collaborator

lvhan028 commented Dec 3, 2024

we will update docs for this pr in another pr

why not put the doc in this PR?

@jinminxi104
Copy link
Collaborator

what is ASCEND_QUANT_RECORD_FILE

ascend only supports offline kv-quant。 ASCEND_QUANT_RECORD_FILE is the file contains all kv scales and offsets.
please refer this doc:https://github.com/DeepLink-org/dlinfer/blob/main/docs/quant/ascend_kv_quant.md

@jinminxi104
Copy link
Collaborator

we will update docs for this pr in another pr

why not put the doc in this PR?

doc updated

@lvhan028 lvhan028 merged commit 866bfa5 into InternLM:main Dec 6, 2024
5 checks passed
@yao-fengchen yao-fengchen deleted the ascend_kv_int8 branch January 24, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants