feat: support dynamic/llama3 rotary embedding in ascend graph mode #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangzhiyi11
force-pushed
the
tzy/support_dynamic_rope
branch
from
b8d8ee3 to
0417c56
Compare
tangzhiyi11
changed the title
tangzhiyi11
force-pushed
the
tzy/support_dynamic_rope
branch
from
0417c56 to
a023459
Compare
tangzhiyi11
force-pushed
the
tzy/support_dynamic_rope
branch
from
a023459 to
f4295ea
Compare
jinminxi104
approved these changes
Nov 5, 2024
CyCle1024
reviewed
Nov 5, 2024
| position_ids_expanded = position_ids.unsqueeze(1) | ||
|
|
||
| inv_freq_expanded = inv_freq_expanded | ||
| position_ids_expanded = position_ids_expanded |
CyCle1024
approved these changes
Nov 5, 2024
AllentDan
pushed a commit
to AllentDan/lmdeploy
that referenced
this pull request
Nov 13, 2024
…nternLM#2670) * feat: support dynamic ntk scaling rotary embedding in ascend graph mode * add llama3 rotary embedding * remove useless codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
support Dynamic NTK scaling and llama3 rotary embedding is supported in ascend graph mode
Modification
ascend rotary_embedding
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist