add linear op on dlinfer platform #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-fengchen
force-pushed
the
yfc/optimize_ascend_mm
branch
2 times, most recently
from
ac9cff5 to
873708b
Compare
yao-fengchen
force-pushed
the
yfc/optimize_ascend_mm
branch
from
873708b to
718ed05
Compare
jinminxi104
approved these changes
Nov 5, 2024
CyCle1024
reviewed
Nov 5, 2024
| from ..linear import LinearBuilder, LinearImpl | ||
|
|
||
|
|
||
| class AscendLinearImpl(LinearImpl): |
There was a problem hiding this comment.
use dlinfer instead of ascend
| @@ -40,6 +40,9 @@ def get_layer_impl_builder(cls, layer_type: OpType): | |||
| elif layer_type == OpType.FusedMoE: | |||
| from .moe import DlinferFusedMoEBuilder | |||
| return DlinferFusedMoEBuilder | |||
| elif layer_type == OpType.Linear: | |||
| from .linear import AscendLinearBuilder | |||
| return AscendLinearBuilder | |||
There was a problem hiding this comment.
use dlinfer instead of ascend
CyCle1024
approved these changes
Nov 5, 2024
jinminxi104
approved these changes
Nov 5, 2024
AllentDan
pushed a commit
to AllentDan/lmdeploy
that referenced
this pull request
Nov 13, 2024
* add linear op on ascend platform * update code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
This PR add linear op on dlinfer.
Modification
Add linear op on dlinfer.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist