set served model name being repo_id from hub before it is downloaded #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllentDan
reviewed
Sep 23, 2024
| @@ -16,6 +16,12 @@ def run(): | |||
| parser = CLI.parser | |||
| args = parser.parse_args() | |||
|
|
|||
| if hasattr(args, 'model_name'): | |||
There was a problem hiding this comment.
Can we modify codes inside? APIs may suffer the same problem.
There was a problem hiding this comment.
pipeline api doesn't need model_name. model_name is only used by v1/models
If we launch api_server through python -m lmdeploy.serve.openai.api_server internlm/internlm2_5-1_8b-chat, the result of v1/models is what we expect "internlm/internlm2_5-1_8-chat".
But if we launch the server by lmdeploy serve api_server, v1/models returns the full local path of the model, because it always try to get_model if the args.model_path doesn't exist
if model_path is not None and not os.path.exists(args.model_path):
args.model_path = get_model(args.model_path,
download_dir=download_dir,
revision=revision)
model_path_or_server = getattr(args, 'model_path_or_server', None)
zhyncs
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the served model name is the full path of the downloaded model, which is not user-friendly.