adjust schedule to improve TTFT in pytorch engine #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvhan028
reviewed
Sep 19, 2024
| @@ -636,7 +631,11 @@ async def __long_context_single_forward(inputs): | |||
| ret['logits'] = ret['logits'][:, last_token_loc] | |||
| return ret | |||
| else: | |||
| return await __long_context_single_forward(inputs) | |||
| ret = await __long_context_single_forward(inputs) | |||
| if not return_logits and not inputs.is_decoding: | |||
There was a problem hiding this comment.
what benefits can we get from this change?
There was a problem hiding this comment.
lmdeploy/lmdeploy/pytorch/engine/engine.py
Lines 518 to 525 in 9cb2583
AllentDan
reviewed
Sep 19, 2024
| return await __long_context_single_forward(inputs) | ||
| ret = await __long_context_single_forward(inputs) | ||
| if not return_logits and not inputs.is_decoding: | ||
| last_token_loc = [-1] |
There was a problem hiding this comment.
Does it influence the following computation?
There was a problem hiding this comment.
__long_context_single_forward is used for very long prefill. Only last output is required.
AllentDan
reviewed
Sep 19, 2024
| loop_count = 1 if is_prefill else (prefill_interval - 1) | ||
| if len(running) == 0: | ||
| raise NoRunningSeqs() | ||
| assert len(running) > 0 |
There was a problem hiding this comment.
how do we make sure it is True?
There was a problem hiding this comment.
lmdeploy/lmdeploy/pytorch/engine/engine.py
Lines 934 to 936 in 9cb2583
Empty requests would be skipped.
AllentDan
approved these changes
Sep 20, 2024
lvhan028
approved these changes
Sep 20, 2024
lvhan028
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prefill enough requests before decoding.