Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor vision model loading #1482

Merged
merged 12 commits into from
Apr 29, 2024
Merged

refactor vision model loading #1482

merged 12 commits into from
Apr 29, 2024

Conversation

irexyc
Copy link
Collaborator

@irexyc irexyc commented Apr 23, 2024

Motivation

Some vlm models have finetuned vision weights and there is no need to download original vision model.

Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May check if deepseek vl also needs refactoring to avoid downloading weight.

@lvhan028
Copy link
Collaborator

lvhan028 commented Apr 28, 2024

The following models still require downloading the vision model

  1. internlm-xcomposer2-4khd-7b
  2. internlm-xcomposer2-vl
  3. internlm-xcomposer2-7b

@lvhan028
Copy link
Collaborator

@AllentDan I tried to install minigemini by

pip install git+https://github.com/dvlab-research/MiniGemini.git --no-deps

But the pipeline still raise error

ModuleNotFoundError: No module named 'minigemini'

@AllentDan
Copy link
Collaborator

@lvhan028
Copy link
Collaborator

@irexyc
Copy link
Collaborator Author

irexyc commented Apr 29, 2024

Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested pipeline and api_server OK.

  • llava-v1.6-34b
  • Mini-Gemini-7B
  • deepseek-vl-1.3b-chat
  • Yi-VL-6B

@lvhan028 lvhan028 merged commit dbd765e into InternLM:main Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants