Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chat cli ArgumentError error happened in python 3.11 #1401

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

RunningLeon
Copy link
Collaborator

Motivation

fix chat cli as in #1396

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zhulinJulia24
Copy link
Collaborator

看代码逻辑,只修复了chat cli。这个pr是否需要一起修复lite、 serve等的cli,我们这边可以手动触发回归自动化 @RunningLeon

@RunningLeon
Copy link
Collaborator Author

看代码逻辑,只修复了chat cli。这个pr是否需要一起修复lite、 serve等的cli,我们这边可以手动触发回归自动化 @RunningLeon

不需要的。

@zhulinJulia24
Copy link
Collaborator

看代码逻辑,只修复了chat cli。这个pr是否需要一起修复lite、 serve等的cli,我们这边可以手动触发回归自动化 @RunningLeon

不需要的。

好滴,我们跑个311下的pr_test看看

Copy link
Collaborator

@zhulinJulia24 zhulinJulia24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

test basic cli under python3.11
'lite', 'serve', 'convert', 'list', 'check_env', 'chat' all passed

Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK with lmdeploy chat command for python 3.10.10

@lvhan028 lvhan028 merged commit 59457eb into InternLM:main Apr 7, 2024
5 checks passed
@lvhan028 lvhan028 changed the title fix chat cli fix chat cli ArgumentError error happened in python 3.11 Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants