Tedit: line positioning, find and substitute "didn't", and break while saving

[MattHeffron]

Describe the bug
Arrow key positioning seems to be off by one sometimes.
Find and Substitute commands didn't search the file.
Also, trying to save a file gave a BREAK.

To Reproduce
Steps to reproduce the behavior:

1. On GitHub I had merged master (b125764) into branch mth35 (PR 2015)
2. I switched to that branch locally, and did a git pull.
3. I emptied my loadups directory and built the loadups locally
4. I copied the lispusers>000-docs>LispUsers-Template.TEdit to lispusers>READ-BDF.TEDIT
5. I started medley with the just built FULL sysout.
6. I opened Tedit on the READ-BDF.TEDIT file, and opened the attached "Expanded Menu"
7. With the mouse, I positioned the type-in cursor at the end of the heading line (after the >>MODULE NAME<<)
8. I typed READ-BDF but it was inserted between the 2 < characters.
9. In the Expanded Menu, I typed >>MODULE NAME<< in the Find field. Clicking on Find did nothing.
10. Similarly, the Substitute in the Expanded Menu did nothing.
11. Using the Find directly from mouse clicking on the Tedit title bar, found the text, but it seemed to be off by 1 position at each end of the highlighting

Note the underline starts 1 character right of correct, and the cursor position is not at the end of the found text, but is one position to the right of the end of the line.

12. I searched for >>DATE<<, and the highlighting was incorrect to the left!

13. I used the Put from the Title bar popup menu, pressed enter to accept the file name and it entered a break.

^ from the BREAK resulted in no file written, but the Tedit Window still showed version 2.

Context (please complete the following information):

• Are you using online.interlisp.org? [yes / no]
• OS: WSL on Win 11
• OS Version: Ubuntu 22.04
• Display/window system: X11
• Host arch: x86_64

[rmkaplan]

The Find from the expanded menu was a bug.

The substitute from the expanded menu may be a confusion about the way it (currently) works: Currently, the substitution takes place only within the current selection. It doesn't run from the current caret forward. (It may be more convenient if it went forward if the confirmflg is on, but the documentation says that it substitutes within the selection.)

I haven't yet been able to replicate the problems with selection misalignment or the break in Put. If you can get the break to happen again, could you show a BT! and also show the arguments to the image object?

[MattHeffron]

I realized that the selection was missing for the Substitute, and have since verified that it worked, although it left the display incorrect (some lines duplicated, and scattered underlining throughout).

I tried just opening the file in Tedit and then immediately doing the Put, without any changes, and that worked.
Then I did the Expanded Menu Substitute of READ-BDF for >>MODULE NAME<< and then did the Put (from the title bar menu) and that got the BREAK. Here is the bitmap from the BREAK with a BT!:

The BREAK on Put appears to be related to the Expanded menu. I closed that Tedit and opened it again. I selected everything, did the Substitute from the title bar menu, then repeated the Put and it did not BREAK. (I never opened the Expanded Menu in this test.)
Also, here is the image of the incorrect display that I mentioned:

[rmkaplan]

PR #2058 addresses the substitute and find issues.

I still have not been able to replicated the break-on-put.

@MattHeffron , can you first test the find and substitute behaviors. Then tell me more precisely what you are inputting to get the put failure. Exactly how did you modify the file before putting?

[MattHeffron]

Here's the detailed steps of the Put problem (with the same loadups as before):
outside of lisp, copy lispusers>000-docs>LispUsers-Template.TEdit to lispusers>000-docs>TEST.TEDIT

in a fresh Full sysyout (including my INIT-loaded files) in the Interlisp Exec:
(CNDIR (MEDLEYDIR "lispusers>000-docs>"))
(TEDIT "TEST.TEDIT")
left mouse click between >>DATE<< and the following .
Use backspace to delete the >>DATE<<
Type: March 8, 2025
Middle mouse on the title bar and select Expanded Menu
Middle mouse on the title bar and select Put
Press Enter to confirm filename
Enters break INVALID-ARGUMENT-LIST
with BT!:

^ from the break
Although the TEdit window shows version 2 of the file, that does not exist.
Type TEST2.TEDIT into field for Put in the Expanded Menu
Repeat the Put from the Title bar popup menu (NOT the Expanded Menu)
It still is asking to confirm the original TEST.TEDIT filename. Press Enter.
Stack overflow break! (Not what I expected!)
I tried looking at a couple of stack frames and ended up in RAID. At this point the original TEST.TEDIT file is now empty.

[MattHeffron]

Regarding Find and Substitute:
Find from the Expanded Menu works correctly with appropriate highlighting.
Substitute has some problems: (each of these tests were after using All on the Expanded Menu)

• Either with or without selecting the Use New Looks (which isn't clear about where these looks come from), the text replacement is in a different Font than the text being replaced. (With Use New Looks it is smaller also.) The "with" case was a different Font from the "without" case. Neither was the same as the Font of the text being replaced.
• If I select the Confirm, on the first substitution, the prompt to confirm isn't displayed; the input cursor is at the beginning of the Tedit prompt window. Pressing Enter did proceed.
• The text of the confirmation prompt is OK to replace? ['q' quits] with a default of Yes pre-entered. In my mind, that prompt implied that OK is what should be entered, and the Yes was a bit confusing. (This wording is probably fine after getting used to TEdit.) ((My Dad was an English teacher, so unexpected grammar catches my attention.))

[rmkaplan]

I see it now, thanks.

[rmkaplan]

For the Put problem, it only happened when the expanded menu is open, and it is trying to fill in the Put and Get fields of that menu with the name of the file that it is trying to Put to. I don't think it matters whether you had actually done anything to the file--it was just doing the Put with the open menu. Tha code for that didn't get updated when I was working through the new menu conventions with Frank.

[rmkaplan]

In terms of substitution looks, if you choose Use New Looks it will use the looks of the replacement string. But then, how do you get change those looks? If you select the replacement string from the document, then it will carry along those looks. But it ought to be the case that you can use the charlooks menu to change the looks in the replacement field, and that needs some work. If you don't choose the new looks, then I think it uses the default character looks at each substitution rather than the looks of the target string. Which seems wrong.

I probably won't be able to do anything more on this until I'm able to get a new loadup in my working directory.

[MattHeffron]

Is it appropriate to close this issue since the Break on Put problem is not yet resolved?

[MattHeffron]

@rmkaplan
I just reproduced the Put BREAK with the detailed steps I described above.
This was with the latest release and master (commit: 97fdcbd).
The stack overflow did not happen. Instead it entered a BREAK with TEDIT.TEST;2 file not found.

[rmkaplan]

In the newer TEDIT-KEY branch I don't see that particular behavior. Before it was crucial that the extended menu with the Put field was open, because it was trying to update that field when you Put from the other menu. That was breaking.

There is still some odd stuff in the coordination between the menu field and what you type in the prompt window when you use the Put in the main menu. But I don't see a break. Just to lock it down, can you do a loadup in the new Tedit key branch and see if you get the break (independent of other oddities)?

---

One odd thing is that if you put a file in the Put field and Put from there, the Put happens, the prompt is updated with the new filename, but the Put menu item didn't is empty. But redisplaying puts in the file name (without the version number).

Also, it doesn't use the field in the extended menu as the prompt when you click Put in the main menu, so they are out of step at least during that interaction. If the current file is TEDIT-TEST.TEDIT (shown in the title bar) and you change the extended menu-field to FOO-TEST.TEDIT, a Put from the menu field will go to FOO-TEST, but a Put from the main menu will still go to TEDIT-TEST. Should it use the prompt from the menu, replace the field in the menu with the promptwindow prompt? What if the menu had a value but then was closed?

[MattHeffron]

@rmkaplan In the rmk76 branch the Put BREAK issue is resolved.