Make SurfaceReconstruction an inout param #7
Conversation
whiterabbit42k
force-pushed
the
inout
branch
from
eb3cb97
to
c379ac9
Compare
|
Looks good from a quick skim, I'll check it in detail when I have a bit more free time. |
Allows passing own SurfaceReconstruction in new function that reuses vectors and indices. The density map is still recalculated for now, but is now optional.
whiterabbit42k
force-pushed
the
inout
branch
from
c379ac9
to
5565153
Compare
|
ok addressed concerns from last review, except the non-derived default, as noted in comment above. |
|
Great thanks. I think for now it won't change much in performance, but it's a starting point. I think it would make sense to go through the code and try to minimize allocations or to try to reuse memory. E.g. by adding the neighborhood list to the output and reusing its memory. However, I'll first focus on reworking the pipeline to use some kind of domain decomposition followed by replacing the hashmaps. But I think it will take some time before it can reach your performance requirements 😅 |
|
Yup agree, I don't think it's a huge bump at the moment; i'm wondering if reusing the density map will be but that wasn't apart of this PR. I also noticed almost all the functions are marked |
Allows passing own SurfaceReconstruction in new
function that reuses vectors and indices.
The density map is still recalculated for now.